[Bug 744771] Check download size and md5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744771

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nirbheek.chauhan at gmail.com

--- Comment #1 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
A little while ago I implemented step #2 for convenience because I realized it
was very frustrating to fix a partial download issue, so I pushed this to
Cerbero:

commit 71001328b968547ce3f5e8d6efa2ec903d0f8549
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Mon Oct 3 16:21:20 2016 +0530

    cerbero: Try to redownload corrupted tarballs

    Earlier, when we encountered an incomplete or corrupted tarball, we
    would error out with a CRC check error (for tarballs) or similar. This
    error would not fix itself if you build the recipe from scratch because
    the 'fetch' stage just checks if the file exists, and if it does,
    assumes that it downloaded successfully.

    You had to manually remove the file, and then when 'extract' errored
    out because the file didn't exist, you'd have to select '1' to build the
    recipe from scratch. This is extremely confusing.

    Now we just overwrite and try to redownload the file once if it's
    corrupted or partially downloaded.


It's not the best solution, but for that we need at least the filesize and
sha256sum (md5 has been broken and is insecure) for each tarball.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.