[Bug 773511] flvdemux: Make "no-more-pads-threshold" a property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773511

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338477|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338477:
 --> (https://bugzilla.gnome.org/review?bug=773511&attachment=338477)

This should be solved in a better way IMHO, that is with the new GstStreams
API, adding/removing pads whenever we want and playbin3/decodebin3 handling
that.

::: gst/flv/gstflvdemux.c
@@ +91,3 @@
+enum
+{
+  PROP_00, /* PROP_0 already used by included gstindex.c */

PROP_0 (== 0) is also not a valid GObject property index

@@ +3648,3 @@
+
+  g_object_class_install_property (gobject_class, PROP_NO_MORE_PADS_THRESHOLD,
+      g_param_spec_int64 ("no-more-pads-threshold", "No-More-Pads Threshold",

Why signed? GstClockTime is unsigned, and default would be GST_CLOCK_TIME_NONE,
i.e. unsigned

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.