[Bug 761947] rtpbasepayload: rtpbasedepayload: Add source-info property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761947

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320987|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 320987:
 --> (https://bugzilla.gnome.org/review?bug=761947&attachment=320987)

Maybe it makes sense to add more information from the RTP header here while
we're at it?

::: gst-libs/gst/rtp/gstrtpbasedepayload.c
@@ +758,3 @@
+    return;
+
+  ssrc = g_new (guint32, 1);

Why allocate that here on the heap?

::: gst-libs/gst/rtp/gstrtpbasedepayload.h
@@ +59,3 @@

+  gboolean source_info;
+

Breaks ABI

::: gst-libs/gst/rtp/gstrtpbasepayload.h
@@ +99,3 @@
   guint    current_ssrc;
   guint    mtu;
+  gboolean source_info;

Breaks ABI

::: gst-libs/gst/rtp/gstrtpmeta.c
@@ +34,3 @@
+ * Returns: (transfer none): the #GstRTPSourceMeta on @buffer.
+ *
+ * Since: 1.8

Everything should be Since: 1.12 now

@@ +99,3 @@
+
+    /* FIXME: HACK: Buffer should be writable at this point. */
+    if (!gst_buffer_is_writable (dst))

So make it a g_warning() or g_return_val_if_fail()

::: gst-libs/gst/rtp/gstrtpmeta.h
@@ +44,3 @@
+  GstMeta meta;
+
+  guint32 *ssrc;

Why a pointer if it can only be one?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.