[Bug 773521] gstplayer: add set accurate seek config API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773521

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338485|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338485:
 --> (https://bugzilla.gnome.org/review?bug=773521&attachment=338485)

Thanks, looks good except for cosmetic things and docs

::: gst-libs/gst/player/gstplayer.c
@@ +4219,3 @@
+ *
+ * set accurate seek flag.
+ */

Since: 1.12 (also for the other function)


Please also explain in more detail in the documentation what this actually
means

@@ +4235,3 @@
+ * @config: a #GstPlayer configuration
+ *
+ * Returns: current position update interval in milliseconds

Copy and paste error from other documentation

@@ +4242,3 @@
+gst_player_config_get_seek_accurate(const GstStructure * config)
+{
+  gboolean  accurate = FALSE;

Double space before the variable name here. please run the .c files through
gst-indent

::: gst-libs/gst/player/gstplayer.h
@@ +205,3 @@
+void           gst_player_config_set_seek_accurate  (GstPlayer *player,
+                                                                gboolean      
   accurate);
+gboolean       gst_player_config_get_seek_accurate  (const GstStructure *
config);

Fix up indentation please

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.