[Bug 773521] gstplayer: add set accurate seek config API

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Oct 26 12:11:57 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773521

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338494|none                        |accepted-commit_after_freez
             status|                            |e

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338494:
 --> (https://bugzilla.gnome.org/review?bug=773521&attachment=338494)

Please run your .c files through gst-indent


(If you can, update the patch, otherwise I'll fix up these things when merging
after 1.10.0)

::: gst-libs/gst/player/gstplayer.c
@@ +4219,3 @@
+ *
+ * set accurate seek flag.
+ * If set, seek process will get to accurate seek position

Basically what this should say is something like:

Enable/disable accurate seeking. When enabled, if possible, elements will try
harder to seek as accurately as possible to the requested seek position and
generally seeking can be slower. Without this flag, they will seek as close to
the requested seek position as is possible without slowing down seeking too
much.



Maybe also taking a look at the wording of the GST_SEEK_FLAG_ACCURATE docs
could help here.

::: gst-libs/gst/player/gstplayer.h
@@ +205,3 @@
+void           gst_player_config_set_seek_accurate  (GstPlayer *player,
+                                                     gboolean  accurate);
+gboolean       gst_player_config_get_seek_accurate  (const GstStructure *
config);

And fix the indentation here to be aligned with the functions above :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list