[Bug 773532] The segfault happens when many clients work with rtsp server with GST_RTSP_LOWER_TRANS_TCP option on.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773532

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338507|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338507:
 --> (https://bugzilla.gnome.org/review?bug=773532&attachment=338507)

This should probably be solved differently somehow, either by using a mutex or
by ensure that the callback is removed early enough.

::: gst/rtsp-server/rtsp-stream-transport.c
@@ +208,3 @@
+  if (priv->user_data) {
+    priv->weak_user_data = g_slice_new (GWeakRef);
+    g_weak_ref_init (priv->weak_user_data, priv->user_data);

GWeakRef only works on GObjects, this can't work here (also allocate it
directly inside the struct instead of using another g_new() here)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.