[Bug 773073] audioconvert: endian conversion optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773073

--- Comment #48 from Petr Kulhavy <brain at jikos.cz> ---
(In reply to Sebastian Dröge (slomo) from comment #44)

> > > > > Maybe needs a g_assert() for gst_audio_converter_supports_inplace() to
> > > > > return TRUE :)
> > > > 
> > > > Isn't this one in _transform() enough?
> > > > 
> > > >   /* allow inbuf==outbuf (i.e. entry from transform_ip)
> > > >    * only if the buffer is writable */
> > > >   g_assert (inbuf != outbuf || inbuf_writable);
> > > 
> > > Yes, but it would be more explicit and understandable to have (also) this
> > > assertion in transform_ip()
> > 
> > Agree, but probably also slower as it is an additional function call.
> 
> It's a macro, almost no cost here
> 

Since glib debug is recommended to be always enabled (otherwise destabilizes
even mostly bug-free code as the config script warns) this is not just a macro.
And valgrind confirms the performance impact:

DLmr        Ir 
3,034 1,122,550    g_assert (gst_audio_converter_supports_inplace
(this->convert));


...after 10205x calls of gst_audio_convert_transform_ip()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.