[Bug 773666] New: baseparse: fix draining with less data than min frame size available

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773666

            Bug ID: 773666
           Summary: baseparse: fix draining with less data than min frame
                    size available
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: t.i.m at zen.co.uk
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 338771
  --> https://bugzilla.gnome.org/attachment.cgi?id=338771&action=edit
baseparse: fix draining with less data than min frame size available

Came across this when debugging some issues with rawvideoparse in a
not-negotiated flow error scenario:

gst-launch-1.0  fakesrc sizetype=random ! queue ! rawvideoparse format=rgb !
appsink caps=video/x-raw,format=I420

First it would not return the flow error properly. After fixing that it would
hit an assert in rawvideoparse

gstrawbaseparse.c:519:gst_raw_base_parse_handle_frame: assertion failed:
(in_size >= frame_size)

Reason is that basesrc sends an EOS in response to the flow error, which makes
basesrc drain, and the draining code passes less than the configured minimum
framesize to the rawvideoparse subclass, which is unexpected.

Not tested the patch a lot, so saving it for now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.