[Bug 773638] wasapisrc, wasapisink: Allow to select device by passing WASAPI Endpoint ID

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773638

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338737|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338737:
 --> (https://bugzilla.gnome.org/review?bug=773638&attachment=338737)

Generally looks good

::: sys/wasapi/gstwasapisink.c
@@ +42,3 @@
+enum
+{
+  PROP_ENDPOINT_ID

0 is not a valid property id (that's why there's often an unused PROP_0). I
wonder why this didn't fail in various ways for you when you tried it.

@@ +200,3 @@
+          ("Failed to get default device"));
+      goto beach;
+    }

You might want to store this in self->endpoint_id then and do a
g_object_notify()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.