[Bug 761947] rtpbasepayload: rtpbasedepayload: Add source-info property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761947

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338605|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338605:
 --> (https://bugzilla.gnome.org/review?bug=761947&attachment=338605)

Thanks for all the explanations, makes sense to me. Having yet another
allocation for the ssrc is annoying though, I'd rather prefer another boolean
in there if there is no "invalid ssrc" value.

::: gst-libs/gst/rtp/gstrtpmeta.c
@@ +1,2 @@
+/* GStreamer
+ * Copyright (C) <2015> Stian Selnes <stian at pexip.com>

We have 2016, and it's almost over already :)

@@ +153,3 @@
+  (void)meta;
+  (void)params;
+  (void)buffer;

You need to initialize all your fields here, to zeroes for example.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.