[Bug 773570] gstplayer: add media info get track num API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773570

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338580|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338580:
 --> (https://bugzilla.gnome.org/review?bug=773570&attachment=338580)

Don't mark files as executable in your patch

::: gst-libs/gst/player/gstplayer-media-info-private.h
@@ +109,1 @@
   GList *subtitle_stream_list;

Instead of this, please use a GQueue here which automatically keeps track of
the length

::: gst-libs/gst/player/gstplayer-media-info.h
@@ +192,3 @@
+guint  gst_player_get_audio_num  (const GstPlayerMediaInfo *info);
+guint  gst_player_get_video_num  (const GstPlayerMediaInfo *info);
+guint  gst_player_get_subtitle_num  (const GstPlayerMediaInfo *info);

num is not a word, and this is also grammatically weird: is it returning the
number of the audio?
Maybe get_number_of_audio_streams()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.