[Bug 773532] The segfault happens when many clients work with rtsp server with GST_RTSP_LOWER_TRANS_TCP option on.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773532

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338727|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338727:
 --> (https://bugzilla.gnome.org/review?bug=773532&attachment=338727)

I think the only way how to fix it without breaking API would be to protect the
callbacks/user_data usage with a mutex everywhere... which is less than ideal
as we would have to keep the mutex locked while sending out data

::: gst/rtsp-server/rtsp-stream-transport.c
@@ +196,2 @@
   g_return_if_fail (GST_IS_RTSP_STREAM_TRANSPORT (trans));
+  g_return_if_fail (user_data == NULL || G_IS_OBJECT (user_data));

This breaks API though, and conventions about user_data/destroy_notify

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.