[Bug 773709] gstplayer: Add get video thumbnail API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773709

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338806|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338806:
 --> (https://bugzilla.gnome.org/review?bug=773709&attachment=338806)

::: gst-libs/gst/player/gstplayer.c
@@ +4208,3 @@
+ *
+ * Get the video sample thumbnail if video existed
+ # the sample includes data in current video and postion

Returns: comes after the description about what the function does, and after
Returns: you should put a "Since: 1.12" here

@@ +4230,3 @@
+      "format", G_TYPE_STRING, "RGB",
+      "width", G_TYPE_INT, 720,
+      "pixel-aspect-ratio", GST_TYPE_FRACTION, 1, 1, NULL);

Why these specific settings? It would probably be better to have an enum here
for: PNG, JPG, raw RGB, raw native. Where raw native is just what comes out of
the decoder.

And width/height parameters which can be -1 for the default

@@ +4250,3 @@
+  gst_structure_get_int (st, "height", &height);
+  if (width <= 0 || height <= 0) {
+    GST_WARNING_OBJECT (self, "height and width of image are less than 0");

This can't really happen, can it?

::: gst-libs/gst/player/gstplayer.h
@@ +203,3 @@
 guint          gst_player_config_get_position_update_interval  (const
GstStructure * config);

+/* get video thumnail at current position */

No "documentation" in the headers :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.