[Bug 769278] aacparse: a few fixes and improvements for LOAS parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769278

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332284|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 332284:
 --> (https://bugzilla.gnome.org/review?bug=769278&attachment=332284)

Can you link here to some sample files that your patch helps with? Also this
sounds like it should be a few separate commits instead of one huge, looks ok
otherwise

::: gst/audioparsers/gstaacparse.c
@@ +586,3 @@
+  (void) extension_audio_object_type;
+  (void) ps;
+  (void) sbr;

Not nice :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.