[Bug 770373] leak tracer: signal handlers need fixing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770373

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 334587 [details] [review]:
> 
> Generally looks good to me, more threads always solve problems ;)
> 
> ::: plugins/tracers/gstleaks.c
> @@ +630,3 @@
> +};
> +
> +/* XXX: this thread is leaked */
> 
> You could shut down this thread when the tracer is finalized/unloaded/...

That's problematic and why I didn't implement that.

The thread is created in class_init not instance_init as I assume the signal
handlers should only be registered once (how it was before) no matter how many
leaks tracers are instantiated.  Adding a class_finalize to a static GType will
never be called and GObject warns of that.  This leaves possibly using
base_init/base_finalize and special casing our single class or registering a
dynamic type.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.