[Bug 770627] adaptivedemux: prevent to set source flag itself

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770627

--- Comment #14 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #11)
> That's indeed a good point, thanks! So maybe the solution for now would
> indeed be to keep the flag unset on stream->stream before adding it as that
> can't be observed from the outside.
> 
> Adding a gst_bin_add() variant for this seems a bit problematic. What would
> you call it, and it would also have to come with a vfunc :) A add_full()
> that takes a GstBinAddPropagateElementFlags? A GstBinAddFlags that contains
> a flag for propagating the SINK/SOURCE/PROVIDES_CLOCK/etc flags?

I'd prefer the opposite to tell which ones to suppress.
gst_bin_add_suppress_flags() but the vfunc thing makes this a bit more
involved.

Another option is to allow setting this as a property in GstBin. No matter how
many sources/sinks we set to adatpvidedemux it should not be considered a
source or a sink. So maybe we want a property to prevent it from propagating
flags at every add.

What do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.