[Bug 770657] basetransform: Don't disable pool in set_allocation if it is not replaced

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 1 14:57:52 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=770657

--- Comment #5 from Philipp Zabel <p.zabel at pengutronix.de> ---
GstBaseSrc already deactivates oldpool only if the pool changed. I can prepare
a patch to also deactivate oldpool if allocator or allocation params changed in
gst_base_src_set_allocation.

GstAudioVisualizer, GstDeinterlace, and GstGLBaseMixer have similar code to
GstBaseTransform. I could add patches for those.

I'm not sure if gst_dvdec_negotiate_pool in GstDVDec and
gst_gdk_pixbuf_dec_setup_pool in GstGdkPixbufDec deserve the same treatment.

GstBaseSink, GstVideoEncoder, GstAudioEncoder and GstAudioDecoder don't call
gst_buffer_pool_set_active at all. GstVideoDecoder calls
gst_buffer_pool_set_active(...,FALSE) only in gst_video_decoder_reset (called
on init and state changes between READY and PAUSED).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list