[Bug 766612] Does not take address pool configuration into account for sending unicast UDP

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766612

--- Comment #40 from Xavier Claessens <xclaesse at gmail.com> ---
<slomo> xclaesse: for your gst-rtsp-server patches, it's all good and working
for you or were there open questions from your side? i'll put aside some time
early next week to look into it, so if there's something specific you want
input about before let me know :)

Replying here to keep record:

That patch is deployed in the product we are working on and works perfectly.
BUT, my case is unicast ipv4 udp only, and I have done NO testing of mcast nor
TCP other than making unit tests pass. I believe I understood how mcast is
supposed to work in theory, so I think I did the right thing there, but I
cannot be sure.

Open questions are:
1) What do we do with gst_rtsp_stream_allocate_udp_sockets()? It has been
released as public API, but IMO it should have been internal API only. My patch
naively replaces its implementation by a g_warn_if_reached().
2) My patch removes the optimization where we avoided the tee+queue. I'm not
really sure how to add it back, and I don't think that should be a merge
blocker. Is it?
3) I'm not sure unit tests are really testing the whole thing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.