[Bug 766612] Does not take address pool configuration into account for sending unicast UDP

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766612

--- Comment #41 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
I've merged them all locally now and made them apply cleanly to git master. It
looks good for unicast but breaks multicast in interesting ways, looking into
that now.

Also going to do a deeper review of the changes once that works.

(In reply to Xavier Claessens from comment #40)
> 1) What do we do with gst_rtsp_stream_allocate_udp_sockets()? It has been
> released as public API, but IMO it should have been internal API only. My
> patch naively replaces its implementation by a g_warn_if_reached().

Like most of the "internal" API there, that's fine. Someone should clean up the
exported API and then we bump the soversion.

> 2) My patch removes the optimization where we avoided the tee+queue. I'm not
> really sure how to add it back, and I don't think that should be a merge
> blocker. Is it?

I'd rather have it working at all "slower", than having it not work very fast.

> 3) I'm not sure unit tests are really testing the whole thing.

They are definitely not (they succeed although multicast is broken currently),
and they are also racy and depending too much on the environment (free ports
for example).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.