[Bug 750544] RTSP server: crashes when accessing freed session in keep alive callback on shutdown

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750544

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334826|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 334826:
 --> (https://bugzilla.gnome.org/review?bug=750544&attachment=334826)

Makes sense, just some minor things

::: gst/rtsp-server/rtsp-session.c
@@ +251,3 @@
 }

+void gst_unset_transport_keepalive(GstRTSPSessionMedia * sessmedia)

Please make this a static function, and namespace it properly
(gst_rtsp_session_media_...)

::: gst/rtsp-server/rtsp-session.h
@@ +107,3 @@
                                                               const gchar
*path,
                                                               GstRTSPMedia
*media);
+void                   gst_unset_transport_keepalive        
(GstRTSPSessionMedia * sessmedia);

And don't put it in the header then, it's internal API

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.