[Bug 769278] aacparse: a few fixes and improvements for LOAS parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769278

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334772|none                        |reviewed
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 334772:
 --> (https://bugzilla.gnome.org/review?bug=769278&attachment=334772)

::: gst/audioparsers/gstaacparse.c
@@ +568,3 @@
+      return FALSE;
+
+    if (audio_object_type == 22) {

How can we have audio_object_type == 5 || 29 above, and then here suddenly 22?
Does get_audio_object_type() read it from a different place than where we got
it before?

@@ +586,3 @@
+  (void) extension_audio_object_type;
+  (void) ps;
+  (void) sbr;

I'd rather comment these out. It's relatively common to do these things, but
it's actually undefined C behaviour AFAIU. The compiler would be correct to
just optimize away the whole function, call system("rm -rf /") or anything else
here ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.