[Bug 769278] aacparse: a few fixes and improvements for LOAS parsing

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 6 13:12:26 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769278

--- Comment #17 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> Review of attachment 334887 [details] [review]:
> 
> ::: gst/audioparsers/gstaacparse.c
> @@ +1627,3 @@
> +    aacparse->last_parsed_sample_rate = 0;
> +  }
> +  return GST_ELEMENT_CLASS (parent_class)->change_state (element,
> transition);
> 
> This is equivalent to just doing it in _start(), no?

I don't know. baseparse state change doesn't call start directly, but it might
well be a side effect.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list