[Bug 769278] aacparse: a few fixes and improvements for LOAS parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769278

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Vincent Penquerc'h from comment #17)
> (In reply to Sebastian Dröge (slomo) from comment #15)
> > Review of attachment 334887 [details] [review] [review]:
> > 
> > ::: gst/audioparsers/gstaacparse.c
> > @@ +1627,3 @@
> > +    aacparse->last_parsed_sample_rate = 0;
> > +  }
> > +  return GST_ELEMENT_CLASS (parent_class)->change_state (element,
> > transition);
> > 
> > This is equivalent to just doing it in _start(), no?
> 
> I don't know. baseparse state change doesn't call start directly, but it
> might well be a side effect.

My point was that start() is the perfect place for this. It's called upon pad
activation, which is exactly the same in the end :) Can you move that there and
remove the state change handler? And then merge

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.