[Bug 769765] v4l2: Skip buffers that have the error flag set

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 6 17:32:36 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=769765

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #333134|none                        |reviewed
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 333134:
 --> (https://bugzilla.gnome.org/review?bug=769765&attachment=333134)

The V4L2 doc don't agree, since the error flag means corruption in the produced
data. I think we should instead validate the size, if it's smaller then
expected, then I'd use the code path where it drops. In decoder scenario,
you'll have the error flag on each buffer the follow a drop, deciding to drop
of not those is implementation dependant.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list