[Bug 770331] player: Implement a playlist API and next/previous commands

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 6 18:18:28 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=770331

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> (In reply to Jonathan Miles from comment #14)
> > If the get_previous/current/next callbacks don't set auxiliary_uris Bad
> > Things Happen.
> > 
> > Suggest this is documented, or aux_uris is set to NULL before calling
> > gst_player_playlist_get_current/next/previous.
> 
> I'll change it so that all arguments are initialized to NULL before calling
> the callbacks. Thanks!

This one is done, they're all set to NULL first.

> > aux_uris and self->uri could leak if the callback fills in the data, but
> > returns false (which is a pretty weird thing for the callback to do).
> 
> And that one, it's indeed weird but weird things happen :)

This one not, the callback is not supposed to set them to anything... and if it
still does we can't know if we're supposed to be free those or not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list