[Bug 770474] Vaapisink plugin does not play 1920 x 1080 video file properly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770474

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |NOTABUG

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Thanks for reporting this issue and for your analysis. But given your
observations I don't see what's the problem.

(In reply to Gautham Kantharaju from comment #2)
> Did more analysis, there found the below issues,
> 
> 1) When h264 related video is played, most of the time container and decoder
> (vaapidecode) retrieves "correct" size "1920 x 1080" but vaapi h264parser
> SPS width x height is "1920 x 1088" because of this
> notify_codec_state_changed() is called, vaapidecode sink pad caps are
> updated, thus calling gstvappi_set_caps(), second time.

Yes, that I want said in comment 1.

> 
> 2) Video size retrieved in set_caps is 1920 x 1088, out rectangle size
> calculated is "1786 x 1080".

The pixel-aspect-ratio is calculated by vaapisink to avoid image deformation.
If the output rectangle cannot show the complete frame, the frame is "resized"
accordingly.

> 
> 3) While you are testing, did you set below vaapisink plugin property,
> fullscreen=true and force-aspect-ratio=false? if set then size is preserved.

Yes, because in that way, the size of the frame matches the output resolution,
and the pixel-aspect-ratio is ignored.

> 
> 4) Even, I used the same video file used by you for testing.

Ok.

In my opinion this is not a bug, so I will close this report as not a bug.

If you think that there is something that needs to be fixed in the
pixel-aspect-ration calculations, please reopen this bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.