[Bug 770953] gstclock: segmentation fault when unschedule

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770953

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335014|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 335014:
 --> (https://bugzilla.gnome.org/review?bug=770953&attachment=335014)

::: gst/gstclock.h
@@ +394,3 @@
   gint                  refcount;
   /*< protected >*/
+  GWeakRef               clock;

This will still break ABI: everything currently using GST_CLOCK_ENTRY_CLOCK()
would need to be recompiled or would do weird things.

You will have to keep this as is, and add the GWeakRef into the padding at the
end, e.g.

union {
  gpointer _gst_reserved[GST_PADDING];
  GWeakRef clock;
} ABI;


And then you can also leave the macro above as is

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.