[Bug 709826] mpegtsmux: performance issue

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 8 12:46:32 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=709826

--- Comment #32 from Jesper Larsen <knorr.jesper at gmail.com> ---
Created attachment 335102
  --> https://bugzilla.gnome.org/attachment.cgi?id=335102&action=edit
[PATCH 1/3] mpegtsmux: Use bufferpool to allocate packets

A buffer pool approach that works for both 188 and 192 byte packets.

It changes the way we write 192 byte packets as well. Instead of pretending we
have a normal 188 byte packet, and memmove at the end, we now write directly
into the buffer at the correct place.

In fact, I think m2ts mode is broken at the moment because of the way PSI
sections are written. Should be fixed up with this commit.

Alexander's approach appended NULL packets in case we could not fill the buffer
up to the alignment. This approach will simply set the size of the buffer to
match what we have, and push without padding. I do not know what we want here?
Should alignment mean "exactly this many packets in one buffer", or should it
mean "no more than this many packets in one buffer"? Maybe we need a to add a
property to discern between these two cases?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list