[Bug 770627] adaptivedemux: prevent to set source flag itself

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770627

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334760|none                        |needs-work
             status|                            |

--- Comment #25 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 334760:
 --> (https://bugzilla.gnome.org/review?bug=770627&attachment=334760)

Just some minor stuff to fix.

::: gst/gstbin.c
@@ +1412,3 @@

+void
+gst_bin_set_supress_flags (GstBin * bin, GstElementFlags flags)

Missing documentation, remember to add the Since marker. Same for the getter
function.

Will this be a 1.10 or 1.12 addition?

@@ +1414,3 @@
+gst_bin_set_supress_flags (GstBin * bin, GstElementFlags flags)
+{
+  g_return_val_if_fail (GST_IS_BIN (bin), NULL);

This should be a g_return_if_fail as the function has no return value.

@@ +1420,3 @@
+  GST_OBJECT_UNLOCK (bin);
+
+  GST_DEBUG_OBJECT (bin, "set supress flags(%d) to bin '%s'", flags,

flags are usually better read in hex format.

::: gst/gstbin.h
@@ +211,3 @@
+/* set and get supress flags */
+void            gst_bin_set_supress_flags (GstBin * bin, GstElementFlags
flags);
+GstElementFlags gst_bin_get_supress_flags (GstBin * bin);

<bikeshed>
I'd prefer:

gst_bin_set/get_supressed_flags
</bikeshed>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.