[Bug 765734] fakesink: Property to not drop out-of-segment buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765734

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Not completely sure either. I believe this was about code the drops buffer in
sink that are completely out of segment (running-time + duration >
segment.start).

If I remember anything, the code does not make any difference if the data is
before or after the segment. That problematic one is when we drop data before
the segment. Though, thinking of it, there should already be code that generate
an EOS if there is a buffer that finishes at or after the segment. It would
need to be checked.

About this bug, your proposition looks fine to me. I don't have any generic
solution in mind. I personally have stopped using this method though due to the
numerous race and wrong results being displayed (multiple fakesink case).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.