[Bug 770921] vaapidecoder loses input caps info

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770921

--- Comment #4 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Hyunjun Ko from comment #3)
> Created attachment 335425 [details] [review]
> vaapidecode: set codec state to decoder during set_format
> 
> Specified decoder's codec state instance and vaapidecode plugin's one is
> different.
> It needs to synchronize them, so that it could avoid losing some video
> information during codec state change in decoder.
> 
> I'm not sure yet if this does make sense.
> Please review this.

The problem with this approach is that it might destroy information that has
been collected from the stream itself into the codec data.

gst-libav and friends solve this problem by keeping the format info from the
sinkpad caps separate from anything extracted from the video stream itself, and
use information from both only when generating new output source caps -
selectively overriding fields (such as framerate, multiview info or
pixel-aspect-ratio) using info from the sinkpad caps if it's been provided.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.