[Bug 711155] wayland: add DMABuf support to wayland sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=711155

--- Comment #83 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 333064:
 --> (https://bugzilla.gnome.org/review?bug=711155&attachment=333064)

::: ext/wayland/wldisplay.c
@@ +218,3 @@
+    self->dmabuf =
+        wl_registry_bind (registry, id, &zwp_linux_dmabuf_v1_interface, 1);
+    zwp_linux_buffer_params_v1_add_listener (self->dmabuf, &dmabuf_listener,

This is calling the wrong function, should be
zwp_linux_dmabuf_v1_add_listener(). Obviously does not compile due to wrong
type.

::: ext/wayland/wllinuxdmabuf.c
@@ +80,3 @@
+
+  mem = gst_buffer_peek_memory (buf, 0);
+  fd = gst_dmabuf_memory_get_fd (mem);

Since you don't include gst/allocators/gstdmabuf.h, it does not compile.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.