[Bug 771210] tests: new queue2: Add higher-resolution low/high-watermark properties unit test is flaky

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Sep 17 13:42:58 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=771210

--- Comment #7 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
@Tim: you're welcome :)

(In reply to Sebastian Dröge (slomo) from comment #4)
> The same is probably also needed for multiqueue?

Unlike with queue2, in multiqueue, there is no single lock for the entire
set_property call. Instead, we have code like this:

    case PROP_LOW_WATERMARK:
      mq->low_watermark = g_value_get_double (value) * MAX_BUFFERING_LEVEL;
      recheck_buffering_status (mq);
      break;

and recheck_buffering_status() does lock the multiqueue mutex. Perhaps this
code should be rewritten so that the integer write is also behind the lock, but
I have found many places in GStreamer where integer writes apparently are
assumed to be atomic..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list