[Bug 771750] New: v4l2videobufferpool: Need set right video meta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771750

            Bug ID: 771750
           Summary: v4l2videobufferpool: Need set right video meta
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: kevinbing.song at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

I need below to make v4l2videodec work. info->offset is get from plane size for
multi plane format. The size maybe bigger then actual video size. But video
decoder will output video buffer with actual video size. So need set actual
video size to video meta.

The reason of below change is _dma_buf_upload_accept() will use the meta offset
to find plane memory. Will report error when memory size is diff with actual
video size.

What's your option?

diff --git a/sys/v4l2/gstv4l2bufferpool.c b/sys/v4l2/gstv4l2bufferpool.c
index a4af436..22a3600 100644
--- a/sys/v4l2/gstv4l2bufferpool.c
+++ b/sys/v4l2/gstv4l2bufferpool.c
@@ -462,10 +462,9 @@ gst_v4l2_buffer_pool_alloc_buffer (GstBufferPool * bpool,
GstBuffer ** buffer,

   /* add metadata to raw video buffers */
   if (pool->add_videometa)
-    gst_buffer_add_video_meta_full (newbuf, GST_VIDEO_FRAME_FLAG_NONE,
+    gst_buffer_add_video_meta (newbuf, GST_VIDEO_FRAME_FLAG_NONE,
         GST_VIDEO_INFO_FORMAT (info), GST_VIDEO_INFO_WIDTH (info),
-        GST_VIDEO_INFO_HEIGHT (info), GST_VIDEO_INFO_N_PLANES (info),
-        info->offset, info->stride);
+        GST_VIDEO_INFO_HEIGHT (info));

   *buffer = newbuf;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.