[Bug 769293] vaapi: optimization of GL texture usage

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=769293

--- Comment #27 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 335976:
 --> (https://bugzilla.gnome.org/review?bug=769293&attachment=335976)

::: gst-libs/gst/vaapi/gstvaapidisplay_egl.c
@@ +246,3 @@
+      if (texture =
+          gst_vaapi_texture_egl_new_wrapped (display, id, target, format,
width,
+              height))

The code style is not correct here, more spaces are required. Use the
gst-indent script to check it out.

@@ +298,3 @@
   dpy_class->display_type = GST_VAAPI_DISPLAY_TYPE_EGL;
+  dpy_class->init = gst_vaapi_display_egl_init;
+  dpy_class->destroy = gst_vaapi_display_egl_destroy;

You did not assigned get_texture_map callback

::: gst-libs/gst/vaapi/gstvaapidisplay_priv.h
@@ +217,3 @@
   /*< public >*/
   GstVaapiDisplayInitFunc init;
+  GstVaapiDisplayDestroyFunc destroy;

Instead of adding a new callback, we should try first to chain up the
destructor.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.