[Bug 771817] New: [PATCH] dx9screencapsrc: throw error for invalid screen index

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771817

            Bug ID: 771817
           Summary: [PATCH] dx9screencapsrc: throw error for invalid
                    screen index
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: fzwoch at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 336062
  --> https://bugzilla.gnome.org/attachment.cgi?id=336062&action=edit
[PATCH] dx9screencapsrc: throw error for invalid screen index

Currently dx9screencapsrc prints a verbose warning in case the screen index is
out of range for the current number of detected monitors. This value is then
dropped.

However there is no initial indication (beside the console print) if it worked
or not. This may result in capturing an unwanted screen as it would capture the
last set index that was not rejected.

This patch sets the index regardless. Instead, the element throws an error when
it tries to run or getting caps for an invalid index.

I think this is more in line with how the avfvideosrc and ksvideosrc elements
work where these kind of errors are received on the pipeline's bus.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.