[Bug 771817] [PATCH] dx9screencapsrc: throw error for invalid screen index

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 22 13:53:11 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=771817

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|---                         |FIXED

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 1489e73df4ec06257d4e56f10f713a8a83bd56cc
Author: Florian Zwoch <fzwoch at gmail.com>
Date:   Thu Sep 22 10:55:03 2016 +0200

    dx9screencapsrc: throw error for invalid screen index

    Currently dx9screencapsrc prints a verbose warning in case the screen
    index is out of range for the current number of detected monitors. This
    value is then dropped.

    However there is no initial indication (beside the console print) if it
    worked or not. This may result in capturing an unwanted screen as it
    would capture the last set index that was not rejected.

    This patch sets the index regardless. Instead, the element throws an
    error when it tries to run or getting caps for an invalid index.

    https://bugzilla.gnome.org/show_bug.cgi?id=771817

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list