[Bug 771761] GstPlayer: add equalizer support [API]

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771761

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sachin Kumar Chauhan from comment #2)
> OK. We can limit ourselves to 3 and 10 band equalizers for now. These
> equalizers have their bands at fixed frequency. 3 band @ 100 Hz, 1100 Hz and
> 11KHz, and 10 band @ 29, 59, 119, 237, 474, 947, 1889, 3770, 7523, 15011 Hz.
> So its not possible to set the center freq.

With the n-band one it is :)

> We can add an API for getting
> center freq. For 3 band its 1100 Hz, and for 10 bands it will be the average
> of 5th and 6th bands.

I meant the center frequency of each band (and the number of bands).

> void gst_player_equalizer_set (GstPlayer * player, GstPlayerEqualizerType
> type);

IMHO this one should just be part of the general settings, not something you
can change at any time during playback. See the user agent setting and tick
interval setting for example.

> double gst_player_equalizer_get_band_gain ( GstPlayer * player, int
> band_index);
> 
> void gst_player_equalizer_set_band_gain ( GstPlayer * player, int
> band_index, double gain);
> 
> int gst_player_equalizer_get_center_freq ( GstPlayer * player);

Need API to get the number of bands, and the per-band center frequency here.

Also as the equalizer is just a setting on GstPlayer, I think all functions
should be like gst_player_set_equalizer_band_gain() and not the other way
around.

> We can set the shape of equalizer by setting gains of each band
> individually, or use an API like below to set it in one shot.
> 
> void gst_player_equalizer_set_shape ( GstPlayer * player, int num_bands,
> double* gains);

You can only do that with the n-band equalizer though, which makes the API
awkward. I would ignore that for now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.