[Bug 722343] waylandsink: fix surface width/height when caps have changed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=722343

--- Comment #17 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
I've sent a very partial implementation. I think the old method previously
proposed was not suitable with the use of viewporter. In that version, I simply
update the render rectangle to be the size of the new request window. Which
will by side effect resize the window. If you have the viewporter, it will
scale the video keeping aspect ratio, if you don't, the video is kept centered
unscaled. This of course is only for the special case where GStreamer create
the top level window. Note, it's not perfect for the non-viewporter case, as we
don't crop the output like ximagesink would do. It's require some work, as you
need to destroy and create new wl_buffer for that. Probably not worth it, to be
useful, this element really depends on viewporter.

commit f6b270d8eb0583940b59af35ea8552876234d335
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Thu Sep 22 18:55:23 2016 -0400

    waylandsink: Update our window size on configure event

    This is specific to when the waylandsink is not being embedded. In
    this patch we pass the render lock to the window so it can safely
    call gst_wl_window_set_render_rectangle() with the new size.

    https://bugzilla.gnome.org/show_bug.cgi?id=722343

Next step will be to push a reconfigure event upstream, and to teach get caps
to prepend an "ideal" resolution. I haven't read yet, but I suppose this is
most likely what Benjamin patch do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.