[Bug 768763] vorbisenc, opusenc reconfiguration broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768763

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336276|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 336276:
 --> (https://bugzilla.gnome.org/review?bug=768763&attachment=336276)

::: ext/ogg/gstoggmux.c
@@ +876,3 @@
+      if (meta->format == GST_FORMAT_DEFAULT) {
+        if (meta->end > duration) {
+          g_assert_not_reached ();

Maybe clip here instead?

@@ +881,3 @@
+        }
+      } else {
+        g_assert_not_reached ();

Maybe without this landmine :) Make it a GST_WARNING and don't clip

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.