[Bug 768763] vorbisenc, opusenc reconfiguration broken

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768763

--- Comment #24 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Vincent Penquerc'h from comment #23)
> (In reply to Sebastian Dröge (slomo) from comment #22)
> > Comment on attachment 336316 [details] [review] [review]
> > vorbisenc: strip after eos samples from the end of the buffer
> > 
> > Now you only need to actually add the clip meta to the buffer :)
> 
> I don't use a clip meta here, I just use the buffer duration to control the
> amount to clip. This is because I don't know the actual duration of the
> whole buffer it's returned, I just know how much there should be (from
> op.granulepos), so I don't know how much samples to clip.

Why not? You know how many samples there are in this frame (including padding)?

Without adding the clip meta here, this is rather useless.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.