[Bug 766990] multifilesink: 'buffer'-mode writes no longer atomic (regression)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766990

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.3

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the bug report, I've reverted the commit now:

commit 023998dd76b449440d267d689d578ae3e7a1bdbd
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Sep 27 10:23:38 2016 +0100

    Revert "multifilesink: streamline the file-switch code a bit"

    This reverts commit f1ceaab02f3f557e23b77b14771a575788f92bb4.

    This broke atomic file writes in "buffer" mode. It did make
    sure that any streamheaders are prepended to each file in
    buffer mode as well, but that's not really needed in practice,
    whereas atomic file writes are, so let's restore the status
    quo ante for now since this was primarily a code cleanup anyway,
    and if anyone needs to streamheaders in buffer mode too they
    can make a patch to implement that differently. Re-implementing
    the atomic writes in the element also seems way too much work.

    https://bugzilla.gnome.org/show_bug.cgi?id=766990

commit 6ab88a7f78839e7931afc726d5e8ff42bacf42e1
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Sep 27 10:22:57 2016 +0100

    Revert "multifilesink: close file on write error with next-file mode is set
to buffer"

    This reverts commit 84e441d2685cf223d348a95be0c5ba693bbf6624.

    This will no longer be needed once we revert f1ceaab02.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.