[Bug 772067] fdkaacenc: fix enc ! dec case

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 27 15:34:32 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=772067

--- Comment #6 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Comment on attachment 336369 [details] [review]
> fix build error with master libfdkaac
> 
> MPEG2 and MPEG4 AAC are not compatible though. What is it producing now? You
> probably want to remove the other then...

The change in libfdkaac had duplicate tests for the MP2 and non-MP2 cases, and
dropped the MP2 ones. I expect it makes the different in another way, eg:


-  if ((audioObjectType==AOT_AAC_LC)     || (audioObjectType==AOT_SBR)     ||
(audioObjectType==AOT_PS)    ||
-      (audioObjectType==AOT_MP2_AAC_LC) || (audioObjectType==AOT_MP2_SBR) ||
(audioObjectType==AOT_MP2_PS) ) {
+  if ( (audioObjectType==AOT_AAC_LC) || (audioObjectType==AOT_SBR) ||
(audioObjectType==AOT_PS) ) {

The commit message says:
       - Code clean up. Remove unneeded pseudo audio object types and transport
types.

(AOT_MP2_AAC_LC is listed as a pseudo type in the header).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list