[Bug 772115] tee: adding inactive pad to running element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772115

--- Comment #11 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Review of attachment 336455:
 --> (https://bugzilla.gnome.org/review?bug=772115&attachment=336455)

::: plugins/elements/gsttee.c
@@ -414,0 +414,7 @@
+  GST_OBJECT_LOCK (tee);
+  if ((GST_STATE (tee) > GST_STATE_READY ||
+          GST_STATE_NEXT (tee) == GST_STATE_PAUSED)) {
... 4 more ...

Here there is a race condition problem when the lock is unlocked:
If the element changes of state between
 - setting the proper active flag to the src pad
 - and adding the pad to the element.
we will have the same problem that doing nothing about the active flag.

This cannot be fixed here because the gst_element_add_pad also locks the
element and we will have a deadlock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.