[Bug 771650] Adding additional tags to FLV header

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771650

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335974|none                        |needs-work
             status|                            |

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 335974:
 --> (https://bugzilla.gnome.org/review?bug=771650&attachment=335974)

::: gst/flv/gstflvmux.c
@@ +861,3 @@
       s = gst_caps_get_structure (caps, 0);
+      if (gst_video_info_from_caps (&info, caps)) {
+        if (info.width > 0) {

Indentation seems wrong here.

Maybe it would still be cleaner to check with gst_structure_has_field() ?

@@ +918,3 @@
+      gst_caps_unref (caps);
+      
+      /* AVC onMeatadata holds good only for h264 encoder

Bad english, please fix.

@@ +942,3 @@
+              !g_strcmp0(profile, "baseline"))
+               idc = 66;
+          else if (!g_strcmp0(profile, "main"))

Indentation is also not correct. Did you disable gst-indent ?

@@ +1001,3 @@
+            
+        tmp = gst_flv_mux_create_number_script_value ("audiodatarate",
+            cpad->bitrate / 1024);

Script value is a gdouble, you are doing an integer division which will loose
precision.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.