[Bug 772151] 1277x719 buffers or larger from vaapipostproc aren't writable GstVideoFilters that do in-place transforms

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772151

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
GstVidoFilter base class maps the buffers with flags that are only managed by
gst_video_frame_map (GST_VIDEO_FRAME_MAP_FLAG_NO_REF).

First observation: somehow gst_video_frame_map() doesn't get the vaapi meta and
uses gst_memory_map() instead of gst_video_meta_map(). Why?

Second observation: gst_video_frame_map() doesn't remove the
GST_VIDEO_FRAME_MAP_FLAG* bits from flag and passes it as is to the mapping
callbacks. Should gst_video_frame_map() remove them?

Finally, gst_vaapi_video_memory_map() is very strict with the mapping flags, if
there is a flag that doesn't manages, bails out with an error.

The main problem is the extra flag that is not managed by
gst_vaapi_video_memory_map(). Thus, the question is shall gst_video_frame_map()
remove its extra flags or shall gst_vaapi_video_memory_map() relax it flags
handling?

As comment, normally is very expensive to upload a frame to the video
processing unit (the GPU in this case) and download it again to main memory.
Perhaps it would be less expensive, in terms of time, to do the color
conversion with software too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.