[Bug 729276] audioresample: Misdetected and/or misused intrinsics headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=729276

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336493|none                        |needs-work
             status|                            |

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 336493:
 --> (https://bugzilla.gnome.org/review?bug=729276&attachment=336493)

Almost good to go

::: configure.ac
@@ +190,3 @@
+SSE41_CFLAGS="-msse4.1"
+
+AS_CXX_COMPILER_FLAG([$SSE_CFLAGS], [HAVE_SSE=1], [HAVE_SSE=0])

Why CXX?

::: gst-libs/gst/audio/Makefile.am
@@ +107,3 @@
+# -version-info that cause a warning on private libs
+
+noinst_LTLIBRARIES += libaudio_resampler_sse.la

Shouldn't this only be compiled in if HAVE_SSE? Same for the others?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.