[Bug 729276] audioresample: Misdetected and/or misused intrinsics headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=729276

--- Comment #35 from Arun Raghavan <arun at arunraghavan.net> ---
(In reply to Sebastian Dröge (slomo) from comment #32)
> Review of attachment 336493 [details] [review]:
> 
> Almost good to go
> 
> ::: configure.ac
> @@ +190,3 @@
> +SSE41_CFLAGS="-msse4.1"
> +
> +AS_CXX_COMPILER_FLAG([$SSE_CFLAGS], [HAVE_SSE=1], [HAVE_SSE=0])
> 
> Why CXX?

Because I suck.

> ::: gst-libs/gst/audio/Makefile.am
> @@ +107,3 @@
> +# -version-info that cause a warning on private libs
> +
> +noinst_LTLIBRARIES += libaudio_resampler_sse.la
> 
> Shouldn't this only be compiled in if HAVE_SSE? Same for the others?

I'd initially done this, but we also have checks for both the header and SSE
support in each of the C files, so it felt redundant. Can put it back if you
think it's clearer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.