[Bug 772186] fdkaac: misc memory related fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772186

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Vincent Penquerc'h from comment #7)
> (In reply to Sebastian Dröge (slomo) from comment #5)
> > Comment on attachment 336520 [details] [review] [review]
> > fix access to freed memory
> > 
> > The ref shouldn't be needed. The buffer is valid for the whole scope of the
> > function. Only the later unmap could be useful.
> 
> It appears that _finish_frame will unref it, a bit too early for us.

It indeed does, yes. Until when do we have to keep the reference though? Why is
it safe to only keep it until end of handle_frame()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.