[Bug 772186] fdkaac: misc memory related fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772186

Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.3

--- Comment #12 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
commit ce59031b10efcf025c820704d8b8b9f6d215a85c
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Sep 29 14:32:15 2016 +0100

    fdkaacenc: fix accessing freed memory

    The buffer data is not always copied in _Fill, and will be
    read in _DecodeFrame. We unmap at the end of the function,
    whether we get there via failure or early out, and keep a
    ref to the buffer to ensure we can use it to unmap the
    memory even after _finish_frame is called, as it unrefs
    the buffer.

    Note that there is an access beyond the allocated buffer,
    which is only apparent when playing from souphttpsrc (ie,
    not from filesrc). This appears to be a bug in the bit
    reading code in libfdkaac AFAICT.

    https://bugzilla.gnome.org/show_bug.cgi?id=772186

commit 58bb21c463dfdb956e1a6811d345c556c9d95b17
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Sep 29 14:31:37 2016 +0100

    fdkaacdec: avoid memory corruption on decoding error

    The buffer size is expected to be in multiples of the sample size,
    not in bytes.

    https://bugzilla.gnome.org/show_bug.cgi?id=772186

commit 95de5bf19395132c67c9b8a2ef93e2a92226e1b2
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Sep 29 14:29:46 2016 +0100

    fdkaacenc: fix buffer leak

    https://bugzilla.gnome.org/show_bug.cgi?id=772186

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.